Feeling Lucky
Feature
PR-6.0-dev
Code Review
[#43276] - [6.0] Admin modules code style
- Closed
- 30 May 2024
- Medium
- Build: 5.1-dev
- # 43276
- Diff
- brianteeman:admin_modules
User tests: Successful: Unsuccessful:
various files are excluded from the automated checks
// Ignore template files as PHP CS fixer can't handle them properly
// PHP-CS-Fixer/PHP-CS-Fixer#3702 (comment)
Summary of Changes
This is a semi-manual review of the site modules to apply
- trailing_comma_in_multiline
- native_function_invocation
- single_line_after_imports
Testing Instructions
code review
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
brianteeman
- comment
- 24 Apr 2024
j4i this marks all layouts as changed on update
??
HLeithner
- comment
- 24 Apr 2024
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
PR-5.1-dev
PR-5.2-dev
Code Review
|
||
| Title |
|
||||||
brianteeman
- comment
- 24 Apr 2024
rebased as requested
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-30 21:51:13 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.1-dev PR-5.2-dev |
||
brianteeman
- comment
- 30 May 2024
closed due to lack of interest
j4i this marks all layouts as changed on update