Feature PR-6.0-dev Code Review Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Apr 2024

various files are excluded from the automated checks
// Ignore template files as PHP CS fixer can't handle them properly
// PHP-CS-Fixer/PHP-CS-Fixer#3702 (comment)

Summary of Changes

This is a semi-manual review of the site modules to apply

  • trailing_comma_in_multiline
  • native_function_invocation

Testing Instructions

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 14 Apr 2024
avatar brianteeman brianteeman - change - 14 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2024
Category Layout
avatar HLeithner
HLeithner - comment - 24 Apr 2024

j4i, this mark all layouts changed on update

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.1] Layouts codestyle
[5.2] Layouts codestyle
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar brianteeman brianteeman - change - 24 Apr 2024
Labels Added: Feature PR-5.1-dev PR-5.2-dev Code Review
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2024
Category Layout Unit Tests Repository Administration com_users com_workflow Front End com_config com_contact com_content com_contenthistory com_fields com_modules Installation Layout
avatar brianteeman brianteeman - change - 24 Apr 2024
Title
[5.2] Layouts codestyle
[6.0] Layouts codestyle
avatar brianteeman brianteeman - edited - 24 Apr 2024
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2024
Category Layout Unit Tests Repository Administration com_users com_workflow Front End com_config com_contact com_content com_contenthistory com_fields com_modules Installation Layout
avatar brianteeman
brianteeman - comment - 24 Apr 2024

rebased to j6 as requested

avatar brianteeman brianteeman - change - 30 May 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-05-30 21:50:38
Closed_By brianteeman
Labels Added: PR-6.0-dev
Removed: PR-5.1-dev PR-5.2-dev
avatar brianteeman
brianteeman - comment - 30 May 2024

closed due to lack of interest

avatar brianteeman brianteeman - close - 30 May 2024

Add a Comment

Login with GitHub to post a comment