[#43275] - [6.0] Site Modules Code Style
- Closed
- 30 May 2024
- Medium
- Build: 5.1-dev
- # 43275
- Diff
- brianteeman:modules
User tests: Successful: Unsuccessful:
various files are excluded from the automated checks
// Ignore template files as PHP CS fixer can't handle them properly
// PHP-CS-Fixer/PHP-CS-Fixer#3702 (comment)
Summary of Changes
This is a semi-manual review of the site modules to apply
- trailing_comma_in_multiline
- native_function_invocation
- single_line_after_imports
Testing Instructions
code review
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
This pull request has been automatically rebased to 5.2-dev.
j4i
==> does that stand for "just for information"
j4i
it's just for information, who ever merged this should be aware that it triggers a warning for all files in the backend. So maybe it's better at 6.0 instead of a minor. I will set this on the maintainers discussion list for tonight.
| Title |
|
||||||
Maintainer decision is to move this pr and the other prs changing so many layouts/template files to 6.0 to reduce the noise of the override checker without a good reason.
Can you rebase your prs or should I do this for you. Then they can be merged.
rebased but I guess 6.0 is a long way behind at the moment?
| Title |
|
||||||
| Category | Modules Front End | ⇒ | Unit Tests Administration com_admin SQL Postgresql com_categories com_config com_content com_fields com_menus com_redirect com_tags com_users Language & Strings |
| Labels |
Added:
Feature
Unit/System Tests
Language Change
PR-5.1-dev
PR-6.0-dev
PR-5.2-dev
Code Review
|
||
| Category | Unit Tests Administration com_admin SQL Postgresql com_categories com_config com_content com_fields com_menus com_redirect com_tags com_users Language & Strings | ⇒ | Modules Front End |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-30 21:51:43 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Removed:
Unit/System Tests
Language Change
PR-5.1-dev
PR-5.2-dev
|
||
closed due to lack of interest
j4i this marks all layouts as changed on update