No Code Attached Yet
avatar conseilgouz
conseilgouz
2 Apr 2024

Steps to reproduce the issue

Update a test website from version 5.0.3 to 5.1.0 RC 1

Expected result

Joomla update OK

Actual result

Extension check get stuck in media/com_joomlaupdate/js/default.js with error at line 302 because of a bunch of deprecated messages

System information (as much as possible)

PHP 8.3.3, Laragon on PC Windows

Additional comments

joomla5 1 0rc1

avatar conseilgouz conseilgouz - open - 2 Apr 2024
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Apr 2024
avatar conseilgouz conseilgouz - change - 2 Apr 2024
Title
[5.1 RC1] Extensions check stuck
[5.1.0 RC1] Extensions check stuck
avatar conseilgouz conseilgouz - edited - 2 Apr 2024
avatar conseilgouz conseilgouz - change - 2 Apr 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-04-02 16:37:01
Closed_By conseilgouz
avatar conseilgouz conseilgouz - close - 2 Apr 2024
avatar conseilgouz
conseilgouz - comment - 2 Apr 2024

Sorry, I messed up, trying to update from 5.1.0 beta 2 to 5.1.0 RC.

avatar conseilgouz conseilgouz - change - 6 Apr 2024
Status Closed New
Closed_Date 2024-04-02 16:37:01
Closed_By conseilgouz
avatar conseilgouz conseilgouz - reopen - 6 Apr 2024
avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

Hi,

I took me a while but I found the condition when this occurs : enable Error reporting to default or higher.

In this case, ajax answer contains a lot of notice message :


Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$folder is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$folder is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$folder is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$folder is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$jversion.full is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Object\LegacyPropertyManagementTrait.php on line 135

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Update::$changelogurl is deprecated in D:\laragon6-------------\www\j503rc\libraries\src\Updater\Update.php on line 452
avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

issue_43196

avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

First notice comes from administrator\components\com_joomlaupdate\src\Model\UpdateModel.php line 1630 :
$update->set('jversion.full', $joomlaTargetVersion);

avatar brianteeman
brianteeman - comment - 6 Apr 2024

very odd. I am using laragon and php 8.3.3 on windows and I have not been able to replicate this

avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

It only appears if you set error reporting to default.

avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

checkCompatibility in UpdateModel is used for non core extension.
So if you have any non core extension, you'll see these notices.

avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

I just tried on a clean Joomla 5.0.3 version with latest Akeeba backup : same error when trying to update to 5.1.0-rc

avatar brianteeman
brianteeman - comment - 6 Apr 2024

I took me a while but I found the condition when this occurs : enable Error reporting to default or higher.

I checked with error reporting set to maximum

Update a test website

I missed this part and was just checking for updates. Will test again

avatar conseilgouz
conseilgouz - comment - 6 Apr 2024

To fix this, we have to add the missing definitions in libraries/src/Updater/Update.php.
I'm trying to create a new PR to fix this, but, as I already have one in progress, I can't achive this.

avatar brianteeman
brianteeman - comment - 6 Apr 2024

I still cant replicate the error

avatar wojsmol
wojsmol - comment - 6 Apr 2024

@brianteeman Deprecated: Creation of dynamic property type of warning is specific to php 8.2+.

avatar brianteeman
brianteeman - comment - 6 Apr 2024

I am using 8.3.3

avatar conseilgouz
conseilgouz - comment - 7 Apr 2024

PR #43226 fixes this.
It took me a while to figure out it had to apply to Joomla 5.0 (I'll fill up a coffee issue asap)

avatar richard67 richard67 - change - 7 Apr 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-04-07 08:20:16
Closed_By richard67
avatar richard67 richard67 - close - 7 Apr 2024
avatar richard67
richard67 - comment - 7 Apr 2024

Closing as having a pull request. See #43226

Add a Comment

Login with GitHub to post a comment