PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
2 Apr 2024

Summary of Changes

This PR implements parts of #43024. In Joomla 6.0, the none behavior is going to be dropped again. When that is the case, it will be difficult to explain why the switch contains the values 1 and 2.

Testing Instructions

codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 2 Apr 2024
avatar Hackwar Hackwar - change - 2 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2024
Category Front End Plugins
avatar brianteeman
brianteeman - comment - 2 Apr 2024

Am I missing some information here/ Is this instead of #43024 ?

avatar Hackwar
Hackwar - comment - 2 Apr 2024

This PR tries to get this change still into 5.1 without enabling the SEF stuff for new installations.

avatar brianteeman
brianteeman - comment - 2 Apr 2024

ah - so you are saying this is an alternative proposal. Would be good to be clearer in the description

avatar richard67
richard67 - comment - 3 Apr 2024

Wouldn't it need to "migrate" values when updating from 5.1.0 Beta 1 or Beta 2 or RC?

Otherwise it could happen that the functionality is enabled when the value is 0.

@LadySolveig @bembelimen What do you think?

avatar bembelimen bembelimen - change - 6 Apr 2024
Labels Added: PR-5.1-dev
avatar bembelimen bembelimen - change - 7 Apr 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-04-07 13:48:43
Closed_By bembelimen
avatar bembelimen bembelimen - close - 7 Apr 2024
avatar bembelimen bembelimen - merge - 7 Apr 2024
avatar bembelimen
bembelimen - comment - 7 Apr 2024

Thx

avatar Hackwar
Hackwar - comment - 8 Apr 2024

Thank you!

Add a Comment

Login with GitHub to post a comment