[#43189] - [4.4] Backendmenu: Fixing import of presets for menu items (ajaxbadge, ...)
- Fixed in Code Base
- 27 Apr 2024
- Medium
- Build: 4.4-dev
- # 43189
- Diff
- Hackwar:4.4-adminmenu-import-preset
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
When importing a backend menu preset into a backend menu, the information for dashboard elements and ajax badges gets lost.
Testing Instructions
- Go to menu manager and filter by admin
- create a new menu and select "Preset - Joomla Main Menu" as preset and save.
- Create a module for the menu and set it to position "menu"
Actual result BEFORE applying this Pull Request
The second backend menu is missing both dashboard and potential ajax badge icons. (The Main Menu preset doesn't have an ajax badge)
Expected result AFTER applying this Pull Request
The dashboard icons show up.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
Did you import the menu items before or after applying the patch? If you imported the preset before applying the patch, that is exactly the issue this PR is trying to fix: The import (which creates a bunch of menu items in the database) does not take care of the additional features. Applying the patch afterwards doesn't change the data which has been written to the database.
For me, all seem to work well after following the process and testing. All good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.
I have tested this item ✅ successfully on 344dff5
For me, all seem to work well after following the process and testing. All good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.
I have tested this item ✅ successfully on 344dff5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-27 13:58:11 |
| Closed_By | ⇒ | MacJoom |
Thank you!
Perhaps I didn't understand the description but for me, nothing seems to have changed before or after having applied the Patch
1st without patch 43189 applied:
FYI: after seeing that the 2nd [test menu] was Access: Public, I also tried it with Access: Special and that did not change the after patch 43189 applied results.
2nd with patch 43189 applied:
@Hackwar what did I miss?