RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
1 Apr 2024

Partial Pull Request for Issue #41268 .

Summary of Changes

While looking at #41268 I noticed that the export of backend menus currently is not properly exporting the attributes for the quicktask, dashboard and ajax-badge feature. This PR fixes that.

Please note that the export also currently does not properly export the tree structure of the menu. This is fixed in #43178.

Please also note, that the backend menu items don't properly support the quicktask, dashboard and ajax badge features in the menu item configuration yet. This is something that needs to be fixed in another PR.

Testing Instructions

  1. Go to menu manager, filter by admin and create a new menu for the administrator. Make sure to select a preset to pre-populate the menu.
  2. In the menu manager, select the menu and click "Download as Preset"
  3. Compare the preset with your download

Actual result BEFORE applying this Pull Request

There is no dashboard="", quicktask="", "ajax-badge="" or icon, title and permission attribute for the quicktask in the XML. The preset and the export differ wildly.

Expected result AFTER applying this Pull Request

There are attributes for the above mentioned features and the preset and export are a lot more similar.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 1 Apr 2024
avatar Hackwar Hackwar - change - 1 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2024
Category Administration com_menus
avatar Hackwar Hackwar - change - 23 Jul 2024
Labels Added: bug PR-4.4-dev
avatar chmst chmst - test_item - 23 Jul 2024 - Tested successfully
avatar chmst
chmst - comment - 23 Jul 2024

I have tested this item ✅ successfully on ee585f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43188.
avatar webnet-assmann webnet-assmann - test_item - 23 Jul 2024 - Tested successfully
avatar webnet-assmann
webnet-assmann - comment - 23 Jul 2024

I have tested this item ✅ successfully on ee585f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43188.

avatar Hackwar Hackwar - change - 23 Jul 2024
Status Pending Ready to Commit
avatar MacJoom MacJoom - change - 24 Jul 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-07-24 16:57:55
Closed_By MacJoom
Labels Added: RTC
avatar MacJoom MacJoom - close - 24 Jul 2024
avatar MacJoom MacJoom - merge - 24 Jul 2024
avatar MacJoom
MacJoom - comment - 24 Jul 2024

Thank you!

Add a Comment

Login with GitHub to post a comment