PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
1 Apr 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) deletes the update SQL scripts "4.4.4-2024-03-28.sql" from the sources and adds these files to the list of files to be deleted on update in file administrator/components/com_admin/script.php so they will be deleted when updating from 4.4 to 5.1.

In general we do not require to be at the latest 4.4.x version for updating to 5.1. The targetplatform values of the 5.0.3 version on https://update.joomla.org/core/list.xml and https://update.joomla.org/core/j4/default.xml allows updating to 5.0.3 from any 4.4.x version, and I assume it will be like that for 5.1.

So theoretically we should keep any 4.4.x update SQL scripts with x > 0 in 5.1 because it could be that people update from a 4.4.0.

Practically that is not necessary as we have to provide another pair of SQL update scripts in 5.1 for people updating from 5.0.x to make the same changes for these cases if not already done. In this case here these are the scripts "5.1.0-2024-03-28.sql". They need a fix for the "if not already done" part, see my other PR #43182 , which hopefully will be accepted.

So it is safe to delete the "4.4.4-2024-03-28.sql" here, and I think it makes sense to do that as that is how we proceeded in past with update SQL scripts from the previous major version.

Testing Instructions

Code review.

Or if you want to make a real test, update the latest 4.4 nightly build to the latest 5.1 nightly build to get the actual result, and update the latest 4.4 nightly build to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

The file mentioned above is still present after updating from the latest 4.4 nightly build, and so it will when updating from 4.4.4.

Expected result AFTER applying this Pull Request

The file mentioned above has been deleted with the update from the latest 4.4 nightly build, and so it will when updating from 4.4.4.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 1 Apr 2024
avatar richard67 richard67 - change - 1 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2024
Category Administration com_admin SQL Postgresql
avatar LadySolveig LadySolveig - change - 1 Apr 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-04-01 15:03:36
Closed_By LadySolveig
Labels Added: PR-5.1-dev
avatar LadySolveig LadySolveig - close - 1 Apr 2024
avatar LadySolveig LadySolveig - merge - 1 Apr 2024
avatar LadySolveig
LadySolveig - comment - 1 Apr 2024

Thank you @richard67

Add a Comment

Login with GitHub to post a comment