Feeling Lucky
Unit/System Tests
PR-5.1-dev
[#43190] - [5.1] Use update channel the correct way
- Fixed in Code Base
- 2 Apr 2024
- Medium
- Build: 5.1-dev
- # 43190
- Diff
- bembelimen:5.1/tuf-checker
User tests: Successful: Unsuccessful:
Alternatives for #43184
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.1-dev
|
||
richard67
- comment
- 1 Apr 2024
@bembelimen It seems this PR breaks the unit tests for the constraint checker.
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
laoneo
- comment
- 2 Apr 2024
Why did you revert the final statement? Sounds logic to me instead of the long description that this class is internal only.
bembelimen
- comment
- 2 Apr 2024
I'm not keen to rewrite and fix all the tests, when I declare them as final (plus, I don't like to close classes that way). Feel free to look into it, but I don't plan to do it before the RC.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-02 09:12:28 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 2 Apr 2024
Thank you!
I have tested this item ✅ successfully on e9e03f8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43190.