?
avatar ht-max
ht-max
20 Sep 2014

Steps to reproduce the issue

default com_banner don't show a description

find & fix this
\components\com_banners\models\banners.php on line 68. Add 'a.description as description,'.

Actual result

System information (as much as possible)

Additional comments

avatar ht-max ht-max - open - 20 Sep 2014
avatar zero-24
zero-24 - comment - 20 Sep 2014

Hi @ht-max can you send your fix against our staging branche?
see here: http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

And please share more information. How can we reproduce the issue and test your fix? etc.

What is the Actual result and what the expected result? Etc.

Thanks

avatar infograf768
infograf768 - comment - 22 Sep 2014

Weird: it seems we never use the description field. It just displays in the edit page.
I agree it should be added to, at least, let people use it in frontend if they wish.

avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Sep 2014

No changes required here.

This field is meant to be used only in the backend for own, private notes and not to show them in public. Where should a description be displayed? Under the banners?

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar jissues-bot
jissues-bot - comment - 24 Sep 2014

Set to "closed" on behalf of @Kubik-Rubik by The JTracker Application at issues.joomla.org

avatar jissues-bot jissues-bot - close - 24 Sep 2014
avatar Kubik-Rubik Kubik-Rubik - change - 24 Sep 2014
Priority Medium Low
Status New Expected Behaviour
avatar jissues-bot jissues-bot - change - 24 Sep 2014
Closed_Date 0000-00-00 00:00:00 2014-09-24 21:54:38
avatar infograf768
infograf768 - comment - 25 Sep 2014

@Kubik-Rubik
I think we should let users decide if they want to use a row in a different way than intended.
Does not cost much to add 'a.description as description,'....

avatar Kubik-Rubik
Kubik-Rubik - comment - 25 Sep 2014

@infograf768
First of all, sorry for closing this issue. I've just changed the status in the tracker, didn't know that it would close the issue here.

Yes, maybe we could implement this feature but it is more than just add this one line! We should communicate this properly because users are used to use this field for their notes and this information should never be displayed directly per default after an update. We have to add this option in the module and also think about how to show the description in the output of the module.

Okay, I will think about a solution and provide something. :-)

avatar jissues-bot jissues-bot - reopen - 25 Sep 2014
avatar Kubik-Rubik Kubik-Rubik - change - 25 Sep 2014
Status Expected Behaviour Confirmed
avatar jissues-bot
jissues-bot - comment - 25 Sep 2014

Set to "open" on behalf of @Kubik-Rubik by The JTracker Application at issues.joomla.org

avatar Kubik-Rubik
Kubik-Rubik - comment - 25 Sep 2014

Reopened - working on it.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar infograf768
infograf768 - comment - 25 Sep 2014

@Kubik-Rubik
I may not have explained myself well.
I do not mean WE should provide a usage in our banner module in core.
If we don't, then no B/C issue at all.
I just meant that someone who wants to use the row in a custom way could do it.

avatar ht-max
ht-max - comment - 25 Sep 2014

I hope joomla in the next version add this field, and don't need editing core on future

avatar infograf768
infograf768 - comment - 25 Sep 2014

Please test
#4344

avatar infograf768
infograf768 - comment - 25 Sep 2014

Implemented for next release

avatar zero-24 zero-24 - close - 25 Sep 2014
avatar infograf768 infograf768 - close - 25 Sep 2014
avatar infograf768 infograf768 - change - 25 Sep 2014
Status Confirmed Closed
Closed_Date 2014-09-24 21:54:38 2014-09-25 12:38:11
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment