default com_banner don't show a description
find & fix this
\components\com_banners\models\banners.php on line 68. Add 'a.description as description,'.
Weird: it seems we never use the description field. It just displays in the edit page.
I agree it should be added to, at least, let people use it in frontend if they wish.
No changes required here.
This field is meant to be used only in the backend for own, private notes and not to show them in public. Where should a description be displayed? Under the banners?
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Set to "closed" on behalf of @Kubik-Rubik by The JTracker Application at issues.joomla.org
Priority | Medium | ⇒ | Low |
Status | New | ⇒ | Expected Behaviour |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-24 21:54:38 |
@Kubik-Rubik
I think we should let users decide if they want to use a row in a different way than intended.
Does not cost much to add 'a.description as description,'....
@infograf768
First of all, sorry for closing this issue. I've just changed the status in the tracker, didn't know that it would close the issue here.
Yes, maybe we could implement this feature but it is more than just add this one line! We should communicate this properly because users are used to use this field for their notes and this information should never be displayed directly per default after an update. We have to add this option in the module and also think about how to show the description in the output of the module.
Okay, I will think about a solution and provide something. :-)
Status | Expected Behaviour | ⇒ | Confirmed |
Set to "open" on behalf of @Kubik-Rubik by The JTracker Application at issues.joomla.org
Reopened - working on it.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@Kubik-Rubik
I may not have explained myself well.
I do not mean WE should provide a usage in our banner module in core.
If we don't, then no B/C issue at all.
I just meant that someone who wants to use the row in a custom way could do it.
I hope joomla in the next version add this field, and don't need editing core on future
Implemented for next release
Status | Confirmed | ⇒ | Closed |
Closed_Date | 2014-09-24 21:54:38 | ⇒ | 2014-09-25 12:38:11 |
Labels |
Added:
?
|
Hi @ht-max can you send your fix against our staging branche?
see here: http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
And please share more information. How can we reproduce the issue and test your fix? etc.
What is the Actual result and what the expected result? Etc.
Thanks