? Success

User tests: Successful: Unsuccessful:

avatar b2z
b2z
21 Sep 2014

How to test

  1. Create menu item "Tagged items" choose any tag you want, but ensure that this tag has empty "Meta Description".
  2. Fill in "Meta Description" in the menu item and save.
  3. Create a "List of all tags" menu item and fill in the metadata.
  4. Proceed to tagged items view and notice that the meta description is empty.
  5. Proceed to list of all tags view and notice that the metadata is empty.
  6. Apply the patch.
  7. Proceed to tagged items view and notice that meta description is taken from the menu item.
  8. Fill in "Meta Description" in the chosen tag and ensure that it overrides meta description from the menu item.
  9. Proceed to list of all tags view and notice that metadata is taken from the menu item.
avatar b2z b2z - open - 21 Sep 2014
avatar jissues-bot jissues-bot - change - 21 Sep 2014
Labels Added: ?
avatar b2z b2z - change - 21 Sep 2014
Category Components Tags
avatar b2z b2z - change - 21 Sep 2014
Easy No Yes
avatar peterlose
peterlose - comment - 21 Sep 2014

Tested. Works fine:

Before patch:

skaermbillede 2014-09-21 kl 15 58 01

After patch:

skaermbillede 2014-09-21 kl 15 58 15

avatar losedk losedk - test_item - 21 Sep 2014 - Tested successfully
avatar b2z
b2z - comment - 22 Sep 2014

Great! Thanks @losedk
Need one test only ;)

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar infograf768
infograf768 - comment - 22 Sep 2014

Is'nt the same patch to be applied to
ROOT/components/com_tags/views/tags/view.html.php
?

avatar b2z
b2z - comment - 22 Sep 2014

@infograf768 seems you are right ;) I will fix it later today.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar b2z
b2z - comment - 22 Sep 2014

Applied the same fix to /components/com_tags/views/tags/view.html.php. But I do not know how to test it...

avatar infograf768
infograf768 - comment - 23 Sep 2014

To test: create a List of all tags menu item.
1. If there is a menu item description for the menu item and no description for the tag, when clicking in the "list of all tags" on a tag to display it, we never get the menu item description but always the site general description.
2. It there is a meta description for the tag, then the tag description displays.

The test is therefore to define only a meta description for the menu item (List of all tags) and none for the tag, then display the tag. It should use the menu item description, which it does after the patch. Adding a meta description for the tag will display it instead.

=>OTHER BUG: When we add a menu item description for "list of all tags" it is not used when displaying the list itself. We always get the general site meta description
For this last one, we need to add this kind of code after $this->document->setTitle($title);

if ($this->params->get('menu-meta_description'))
        {
            $this->document->setDescription($this->params->get('menu-meta_description'));
        }

        if ($this->params->get('menu-meta_keywords'))
        {
            $this->document->setMetadata('keywords', $this->params->get('menu-meta_keywords'));
        }

        if ($this->params->get('robots'))
        {
            $this->document->setMetadata('robots', $this->params->get('robots'));
        }
avatar b2z
b2z - comment - 23 Sep 2014

@infograf768 thank you! I will submit a fix later today for the "List of all tags" and will update testing instructions.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar b2z
b2z - comment - 23 Sep 2014

The fix is submitted. Test instructions are updated. Please retest @infograf768 and @losedk
Thank you!

avatar MAT978 MAT978 - test_item - 24 Sep 2014 - Tested successfully
avatar MAT978
MAT978 - comment - 24 Sep 2014

@test
able to reproduce the issue then the patch works as described:
-Meta Description for the tagged items menu appears

  • then after filling the meta description for the concerned Tag, this is the one to appear.

Also works as expected for the "list of all tags" issue specified by JM
Thanks

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar b2z b2z - change - 25 Sep 2014
The description was changed
avatar b2z
b2z - comment - 11 Oct 2014

Do we need more tests to merge?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4313.

avatar infograf768 infograf768 - close - 13 Oct 2014
avatar infograf768 infograf768 - reference | 741b12a - 13 Oct 14
avatar infograf768 infograf768 - merge - 13 Oct 2014
avatar infograf768 infograf768 - close - 13 Oct 2014
avatar infograf768 infograf768 - change - 13 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-13 06:18:01
avatar mbabker mbabker - change - 16 Oct 2014
Milestone
avatar mbabker mbabker - change - 22 Nov 2014
Milestone
avatar mbabker mbabker - change - 22 Nov 2014
Milestone Added:
avatar mbabker mbabker - change - 22 Nov 2014
Milestone Added:
avatar mbabker mbabker - change - 22 Nov 2014
Milestone
avatar b2z b2z - head_ref_deleted - 3 Mar 2015

Add a Comment

Login with GitHub to post a comment