User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Category | ⇒ | Components Tags |
Easy | No | ⇒ | Yes |
Great! Thanks @losedk
Need one test only ;)
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Is'nt the same patch to be applied to
ROOT/components/com_tags/views/tags/view.html.php
?
@infograf768 seems you are right ;) I will fix it later today.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Applied the same fix to /components/com_tags/views/tags/view.html.php
. But I do not know how to test it...
To test: create a List of all tags menu item.
1. If there is a menu item description for the menu item and no description for the tag, when clicking in the "list of all tags" on a tag to display it, we never get the menu item description but always the site general description.
2. It there is a meta description for the tag, then the tag description displays.
The test is therefore to define only a meta description for the menu item (List of all tags) and none for the tag, then display the tag. It should use the menu item description, which it does after the patch. Adding a meta description for the tag will display it instead.
=>OTHER BUG: When we add a menu item description for "list of all tags" it is not used when displaying the list itself. We always get the general site meta description
For this last one, we need to add this kind of code after $this->document->setTitle($title);
if ($this->params->get('menu-meta_description'))
{
$this->document->setDescription($this->params->get('menu-meta_description'));
}
if ($this->params->get('menu-meta_keywords'))
{
$this->document->setMetadata('keywords', $this->params->get('menu-meta_keywords'));
}
if ($this->params->get('robots'))
{
$this->document->setMetadata('robots', $this->params->get('robots'));
}
@infograf768 thank you! I will submit a fix later today for the "List of all tags" and will update testing instructions.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
The fix is submitted. Test instructions are updated. Please retest @infograf768 and @losedk
Thank you!
@test
able to reproduce the issue then the patch works as described:
-Meta Description for the tagged items menu appears
Also works as expected for the "list of all tags" issue specified by JM
Thanks
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Do we need more tests to merge?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4313.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-13 06:18:01 |
Milestone |
Milestone |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Tested. Works fine:
Before patch:
After patch: