[#4311] - [CS] CodeStyle on joomla.sql
- Closed
- 23 Aug 2015
- Medium
- Build: staging
- # 4311
- Diff
- shur:patch-7
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If you export a live site's database and compare it to the core joomla.sql you'll see lots of minor differences. This hardens the database examination and shows that joomla.sql contains many code style mistakes.
This is the second portion of CS changes.
First portion: #4298
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style |
I'm not sure about the following lines: 400, 1705, 1706, 1716
I need advice.
There is no default value in these lines. So it should be, or it is done by mistake?
For asset_id columns, don't assign a default value. That's essentially a foreign key to the #__assets table and can cause unexpected behavior if the values don't match up. I think I've seen issues with it being set to 0 in the past too.
Try one more time please. I'm still getting conflicts.
| Labels |
Added:
?
|
||
Check now.
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
To simplify I will divide this PR into several PRs.
After all small PRs will be processed, I'll close this big PR.
@shur The first portion PR has been merged. What is the status on this one? Are you going to make smaller ones or can we test this one?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4311.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-23 18:11:49 |
| Closed_By | ⇒ | zero-24 |
I'm not sure about the following lines: 400, 1705, 1706, 1716
I need advice.
For example here, this line 1706:
'asset_id' int(10) unsigned COMMENT 'FK to the #__assets table.',should look like:
'asset_id' int(10) unsigned NOT NULL DEFAULT 0 COMMENT 'FK to the #__assets table.',