Feeling Lucky
bug
PR-5.2-dev
[#43118] - [5.2] Router: Only throw 404 exception when parsing current URL
- Closed
- 3 Apr 2024
- Medium
- Build: 5.2-dev
- # 43118
- Diff
- Hackwar:5.2-router-parsing
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42766, #27356 .
Summary of Changes
Right now, when the router is called to parse a URL, a failing parse always throws a 404 exception. This is actually not something that we want. This PR changes the router to only throw a 404 when the $setvars switch is set, since we do that only when we do the initial parsing. If parsing a URL fails without the switch, the returned array should be empty.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
bug
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-03 17:33:47 |
| Closed_By | ⇒ | Hackwar |
After discussion in the CMS maintainer meeting, we decided that this is the wrong approach. I'm closing this PR. If you run the parse() method, you have to wrap this with a try-catch block.