Feeling Lucky
RTC
NPM Resource Changed
PR-5.1-dev
[#43117] - Add missing variable to light theme
- Fixed in Code Base
- 24 Mar 2024
- Medium
- Build: 5.1-dev
- # 43117
- Diff
- coolcat-creations:5.1-dev-42986#issuecomment-1991930151
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Add missing variable in light mode
Actual result BEFORE applying this Pull Request
Before this PR
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
coolcat-creations
- comment
- 22 Mar 2024
Yes it should. I dont know why people decide to use different classes for same things all over the backend. That makes things really hard. :-)
brianteeman
- comment
- 22 Mar 2024
I would fix the markup to use the correct class rather than the css
coolcat-creations
- comment
- 22 Mar 2024
Ok then I need a decision if this should be a btn-secondary or in all other views a btn-info
Anyway this PR is good to fix any appeareance of btn-info if used somewhere
Quy
- comment
- 22 Mar 2024
I have tested this item ✅ successfully on 2d367a0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117.
viocassel
- comment
- 22 Mar 2024
I have tested this item ✅ successfully on 2d367a0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
Quy
- comment
- 22 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117.
| Labels |
Added:
RTC
|
||
wilsonge
- comment
- 24 Mar 2024
Thanks!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-24 02:06:57 |
| Closed_By | ⇒ | wilsonge |
should it not be the same as elsewhere eg com_categories
