[#43116] - [5.1] menu icon js fix [a11y]
- Fixed in Code Base
- 27 Mar 2024
- Medium
- Build: 5.1-dev
- # 43116
- Diff
- brianteeman:menu
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43101 .
Summary of Changes
Only add a tabindex to menu items that are not links
Testing Instructions
- Create a menu module that is using the default layout (not the cassiopeia layout) and publish in the menu position
- Create a menu item of type url and add a link icon class of "fas fa-envelope"
- Create a menu item of type url and add a link icon class of "fas fa-envelope" and Display Menu Item Title - No
- Create a menu item of type header
as it is a js change you will need to either use a pre-built package or `npm build:js"
Actual result BEFORE applying this Pull Request
When using the keyboard to navigate the menu using the tab key there will be multiple extra tab stops as shown below
Expected result AFTER applying this Pull Request
extra tab stops are no longer present as shown below
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
thanks @C-Lodder
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 871b7c1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43116.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43116.
| Labels |
Added:
RTC
|
||
Thank you @brianteeman and also for testing @Quy and @exlemor
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-27 17:57:02 |
| Closed_By | ⇒ | LadySolveig |
thanks
I have tested this item ✅ successfully on 871b7c1
I have tested this successfully from the Joomla_5.1.0-beta3-dev+pr.43116-Development-Update_Package.zip update.
I doubt this matters, but using the TAB key to switch from 1 menu item to another only worked with Chrome, Vivaldi and Opera...
For Firefox, Safari and Orion: it was the right/left arrow that does the same function.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43116.