Feeling Lucky
bug
PR-5.2-dev
[#43119] - [5.2] Router: Check directly for RouterInterface
- Fixed in Code Base
- 22 Mar 2024
- Medium
- Build: 5.2-dev
- # 43119
- Diff
- Hackwar:5.2-router-component
User tests: Successful: Unsuccessful:
Summary of Changes
I have no idea why I took this complicated approach of using Reflection to see if the given object implements the RouterInterface. This PR changes the code to be simpler and to just use the instanceof operator.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Hackwar
- comment
- 22 Mar 2024
For 6.0 we should enforce the interface by typehinting the input vars properly.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-22 14:28:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
bug
PR-5.2-dev
|
||
wilsonge
- comment
- 22 Mar 2024
Trivial change so merging with a single good test + my code review
I have tested this item ✅ successfully on 062d2f9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43119.