RTC bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
18 Mar 2024

Summary of Changes

With the new options to improve the routing, we introduced redirects when the URL does not meet our expectations. These redirects only take effect when the request is for a frontend page and when it is a GET request. However this also means that for example AJAX calls or calls to JSON/XML output gets redirected. This isn't an issue because GET requests do automatically follow redirects, but it would mean that such a request would be received, redirected and then received again, thus creating 2 requests on the server. In order to reduce load, this PR thus excludes all requests which aren't for HTML documents.

Testing Instructions

  1. Set the SEF plugin to remove a trailing slash
  2. Go to a category view in the frontend and add /?format=feed to the URL

Actual result BEFORE applying this Pull Request

You get redirected to the URL without the trailing slash and then receive the feed.

Expected result AFTER applying this Pull Request

You get the feed output directly without a redirect.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 18 Mar 2024
avatar Hackwar Hackwar - change - 18 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2024
Category Front End Plugins
avatar Fedik Fedik - test_item - 18 Mar 2024 - Tested successfully
avatar Fedik
Fedik - comment - 18 Mar 2024

I have tested this item ✅ successfully on bc8d43c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43083.

avatar SniperSister SniperSister - test_item - 18 Mar 2024 - Tested successfully
avatar SniperSister
SniperSister - comment - 18 Mar 2024

I have tested this item ✅ successfully on bc8d43c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43083.

avatar alikon alikon - change - 18 Mar 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43083.

avatar LadySolveig LadySolveig - change - 18 Mar 2024
Labels Added: RTC bug PR-5.1-dev
avatar LadySolveig LadySolveig - change - 18 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-18 21:59:08
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 18 Mar 2024
avatar LadySolveig LadySolveig - merge - 18 Mar 2024
avatar LadySolveig
LadySolveig - comment - 18 Mar 2024

Thank you @Hackwar ? and also for testing @Fedik @SniperSister

Add a Comment

Login with GitHub to post a comment