Feeling Lucky
PR-5.0-dev
[#43084] - [5.0] Cassiopeia. Load colors_xyz.css after template.css
- Closed
- 18 Mar 2024
- Medium
- Build: 5.0-dev
- # 43084
- Diff
- ReLater:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #43071
Summary of Changes
- Add a weight attribute to registerAndUseStyle().
Testing Instructions
- Have a brand new site with a Cassiopeia theme.
- Switch to the "Alternative" color theme.
- Go to frontend. Open a page. Inspect an A tag somewhere in text.
Actual result BEFORE applying this Pull Request
- Value of
--link-coloris not from loaded file media/templates/site/cassiopeia/css/global/colors_alternative.min.css whichis --link-color: #30638d; - but is (see image)
Expected result AFTER applying this Pull Request
- See image:
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-18 11:42:44 |
| Closed_By | ⇒ | ReLater | |
| Labels |
Added:
PR-5.0-dev
|
||
ReLater
- comment
- 18 Mar 2024
But it should have been ported to the 5.1-dev branch.
I shall open a new PR for 5.1-dev, adapt 42479 or ????
ReLater
- comment
- 18 Mar 2024
Sorry for confusion. The fix from pr 42479 is already in 5.1-dev. All fine now ;-)
Closing as this has already been fixed for Joomla 4.4 in https://github.com/joomla/joomla-cms/pull/42794/files in another way but not ported to Joomla 5 yet.