RTC NPM Resource Changed bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
18 Mar 2024

Summary of Changes

Fix for #43022

Add missing dependency in media-select field

Testing Instructions

Run npm install.

Edit template settings on frontend, try select a logo.

Actual result BEFORE applying this Pull Request

nothing works

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 18 Mar 2024
avatar Fedik Fedik - change - 18 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2024
Category Repository NPM Change
avatar Fedik Fedik - change - 18 Mar 2024
The description was changed
avatar Fedik Fedik - edited - 18 Mar 2024
avatar Kostelano Kostelano - test_item - 18 Mar 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 18 Mar 2024

I have tested this item ✅ successfully on 8f06074

Works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43080.

avatar viocassel viocassel - test_item - 18 Mar 2024 - Tested successfully
avatar viocassel
viocassel - comment - 18 Mar 2024

I have tested this item ✅ successfully on 8f06074


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43080.

avatar Quy Quy - change - 18 Mar 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug
avatar Quy
Quy - comment - 18 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43080.

avatar Quy Quy - change - 18 Mar 2024
Labels Added: RTC
avatar Quy Quy - change - 18 Mar 2024
Labels Added: PR-5.1-dev
avatar LadySolveig
LadySolveig - comment - 27 Mar 2024

Thank you @Fedik and also for testing @Kostelano @viocassel

avatar LadySolveig LadySolveig - change - 27 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-27 18:04:19
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 27 Mar 2024
avatar LadySolveig LadySolveig - merge - 27 Mar 2024

Add a Comment

Login with GitHub to post a comment