[#43038] - [5.1] Tour primary button changes size on hover, adding annoying flicker
- Fixed in Code Base
- 17 Mar 2024
- Medium
- Build: 5.1-dev
- # 43038
- Diff
- obuisard:guided-tours-buttons
User tests: Successful: Unsuccessful:
Summary of Changes
shepherd-button-primary button needs to have a border always.
Replaced 'border-color' properties with 'border'.
It also ensures buttons for the tour are consistent to the buttons of the rest of the interface (in dark mode especially, where borders are more prominent).
Testing Instructions
Get the latest 5.1 version.
Start a tour.
Hover the 'Start' button.
Actual result BEFORE applying this Pull Request
The Start button gets a border on hover, while the initial button does not have a border, resulting on a certain flicker.
Expected result AFTER applying this Pull Request
No flicker, the primary button looks like the rest of the primary buttons on the page.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Title |
|
||||||
I have tested this item ✅ successfully on 17f45b7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43038.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43038.
I have tested this item ✅ successfully on 17f45b7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43038.
| Labels |
Added:
RTC
|
||
bembelimen
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-17 14:54:15 |
| Closed_By | ⇒ | bembelimen |
I have tested this item ✅ successfully on 17f45b7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43038.