[#43037] - [5.1] Guided tours dialog box outline is invisible in dark mode
- Fixed in Code Base
- 16 Mar 2024
- Medium
- Build: 5.1-dev
- # 43037
- Diff
- obuisard:guided-tours-dialog
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Add CSS to make the Shepherd dialog match the rest of the dialog windows in the interface
Testing Instructions
Use the latest 5.1 version available.
Turn into dark mode if your browser is not using it already.
Start a tour.
Check that the outline is present.
Turn light mode.
Check that the dialog box looks alright.
Actual result BEFORE applying this Pull Request
The dialog box does not seem to have boundaries or any outline.
Expected result AFTER applying this Pull Request
The dialog box has an outline like the rest of the modals in the interface.
Note: the outline may look dim, but this is something that can be changed in the template.
Any change in the overall interface will be reflected in the guided tours dialog boxes.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
I have tested this item ✅ successfully on dfccd98
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43037.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43037.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-16 10:24:17 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item ✅ successfully on dfccd98
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43037.