[#43039] - [4.4] Prevent step target to be recorded with empty spaces and prevent tour run fails
- Closed
- 8 Aug 2024
- Medium
- Build: 4.4-dev
- # 43039
- Diff
- obuisard:guided-tours-trimtarget
User tests: Successful: Unsuccessful:
Summary of Changes
The step target is trimmed to avoid javascript errors and preventing a tour to start (with an error message that does not really explain what was wrong)
Testing Instructions
Edit a tour step and edit the target, adding spaces before and after the content of the field.
Run the tour you have edited the step from.
The tour MAY fail (depending on the browser/system used). It failed on Safari.
Apply the patch.
Edit the target field for the step (so it can be saved). Once saved, the step target field should not contain any space.
Actual result BEFORE applying this Pull Request
The tour may not start (an error message is shown when you start the tour).
Expected result AFTER applying this Pull Request
The tour runs.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-4.4-dev
|
||
| Category | Administration | ⇒ | Administration Front End Plugins |
HLeithner
- 
Can't test Pull Request as tour not failed on
- MacOS 14.5
- Safari 17.5, Firefox 129
- Error Reporting: Maximum.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-08 20:17:49 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
bug
|
||
I am going to close this as nobody has been able to reproduce.
Thank you all for testing :-)
@obuisard
Tested this under Joomla 4.4.4 and under Safari v17.4.1 (19618.1.15.11.14) on Mac OS Sonoma 14.4.1 and I could not have it fail. [I have checked that there is a space before and after the field].
Sorry.