[#43023] - [5.1] spinner support for color schemes
- Fixed in Code Base
- 16 Mar 2024
- Medium
- Build: 5.1-dev
- # 43023
- Diff
- dgrammatiko:5.1-dev-spinner
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43014 .
Summary of Changes
- Add support for dark/light modes
Testing Instructions
Follow the instructions on the linked issue
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
Your PR is valid and affects one view but doesn't touch the background color of the spinner.
This PR adapts the spinner to the dark/light convention already introduced in another PR. The spinner is used in many places like article edit view if you change a category and there are some custom fields...
I have tested this item ✅ successfully on c9c7ce0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.
The logo is big when installing a sample data.
I have tested this item ✅ successfully on 6a79403
Beautiful! Thank you!!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.
I have tested this item ✅ successfully on 6a79403
?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-16 10:11:04 |
| Closed_By | ⇒ | bembelimen |
Thx
what was wrong with #43018