Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43024] - [5.2] SEF: Enable new SEF options for new installations

Feature RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Mar 2024

Summary of Changes

This PR enables the new SEF features for new installations by default. It also changes the value of the trailingslash option. In Joomla 6.0 we want to remove the "Do nothing" option again and it would be stupid to then have to switch between the values 1 and 2 instead of 0 and 1.

Testing Instructions

Codereview?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 14 Mar 2024
avatar Hackwar Hackwar - change - 14 Mar 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2024
Category ⇒ SQL Installation Postgresql Front End Plugins
avatar brianteeman
brianteeman - comment - 14 Mar 2024

shouldnt the default value in the xml match the value being set in the install sql?

avatar Hackwar
Hackwar - comment - 14 Mar 2024

No, because the default for existing installations should be the current behavior, not the new behavior. If I set the default to the value in the installation SQL, then a user editing the SEF plugin, not changing anything and then saving would have the new behavior.

avatar bembelimen bembelimen - change - 14 Mar 2024
Labels Added: PR-5.1-dev
avatar Hackwar Hackwar - change - 9 Apr 2024
Title
…
[5.1] Enable new SEF options for new installations
[5.1] SEF: Enable new SEF options for new installations
avatar Hackwar Hackwar - edited - 9 Apr 2024
avatar Hackwar Hackwar - change - 9 Apr 2024
Title
…
[5.1] SEF: Enable new SEF options for new installations
[5.2] SEF: Enable new SEF options for new installations
avatar Hackwar Hackwar - edited - 9 Apr 2024
avatar Hackwar Hackwar - change - 8 Jul 2024
Labels Added: Feature
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2024
Category SQL Installation Postgresql Front End Plugins ⇒ SQL Installation Postgresql
avatar Hackwar Hackwar - change - 16 Jul 2024
Labels Added: PR-5.2-dev
avatar SniperSister SniperSister - test_item - 21 Jul 2024 - Tested successfully
avatar SniperSister
SniperSister - comment - 21 Jul 2024

I have tested this item ✅ successfully on d03b7bb

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024.

avatar Quy Quy - change - 15 Aug 2024
Labels Removed: PR-5.1-dev
avatar Quy Quy - alter_testresult - 15 Aug 2024 - SniperSister: Tested successfully
avatar Quy Quy - test_item - 15 Aug 2024 - Tested successfully
avatar Quy
Quy - comment - 15 Aug 2024

I have tested this item ✅ successfully on f64664b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024.

avatar Quy Quy - change - 15 Aug 2024
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 15 Aug 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024.

avatar pe7er pe7er - change - 15 Aug 2024
Labels Added: RTC
avatar pe7er pe7er - close - 15 Aug 2024
avatar pe7er pe7er - merge - 15 Aug 2024
avatar pe7er pe7er - change - 15 Aug 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-08-15 19:53:30
Closed_By ⇒ pe7er
avatar pe7er
pe7er - comment - 15 Aug 2024

Thanks @Hackwar !

Add a Comment

Login with GitHub to post a comment