RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
7 Mar 2024

Pull Request for Issue # .

Summary of Changes

This PR makes small improvements to the code by replacing deprecated Factory::getDbo() with $this->getDbo(). Within the class, we can use $this->getDbo() to get database object, see https://github.com/joomla/joomla-cms/blob/5.1-dev/libraries/src/Updater/Updater.php#L196 for code using in same class.

Testing Instructions

Code review should be enough.

Actual result BEFORE applying this Pull Request

Works, but using deprecated code.

Expected result AFTER applying this Pull Request

Works without using deprecated code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomdonation joomdonation - open - 7 Mar 2024
avatar joomdonation joomdonation - change - 7 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2024
Category Libraries
avatar alikon alikon - test_item - 7 Mar 2024 - Tested successfully
avatar alikon
alikon - comment - 7 Mar 2024

I have tested this item ✅ successfully on c2aac77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42977.

avatar sandewt sandewt - test_item - 7 Mar 2024 - Tested successfully
avatar sandewt
sandewt - comment - 7 Mar 2024

I have tested this item ✅ successfully on c2aac77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42977.

avatar alikon alikon - change - 7 Mar 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 7 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42977.

avatar Quy Quy - change - 7 Mar 2024
Labels Added: PR-5.1-dev
avatar Quy Quy - change - 7 Mar 2024
Labels Added: RTC
avatar bembelimen bembelimen - change - 13 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-13 18:36:35
Closed_By bembelimen
avatar bembelimen bembelimen - close - 13 Mar 2024
avatar bembelimen bembelimen - merge - 13 Mar 2024
avatar bembelimen
bembelimen - comment - 13 Mar 2024

Thx

Add a Comment

Login with GitHub to post a comment