Feeling Lucky
RTC
PR-5.1-dev
[#42977] - [5.1] Replace deprecated Factory::getDbo() by $this->getDbo()
- Fixed in Code Base
- 13 Mar 2024
- Medium
- Build: 5.1-dev
- # 42977
- Diff
- joomdonation:db_in_update_adapter
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes small improvements to the code by replacing deprecated Factory::getDbo() with $this->getDbo(). Within the class, we can use $this->getDbo() to get database object, see https://github.com/joomla/joomla-cms/blob/5.1-dev/libraries/src/Updater/Updater.php#L196 for code using in same class.
Testing Instructions
Code review should be enough.
Actual result BEFORE applying this Pull Request
Works, but using deprecated code.
Expected result AFTER applying this Pull Request
Works without using deprecated code.
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
sandewt
- comment
- 7 Mar 2024
I have tested this item ✅ successfully on c2aac77
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42977.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 7 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42977.
Quy
- | Labels |
Added:
PR-5.1-dev
|
||
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-13 18:36:35 |
| Closed_By | ⇒ | bembelimen |
bembelimen
- comment
- 13 Mar 2024
Thx
I have tested this item ✅ successfully on c2aac77
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42977.