Feeling Lucky
PR-5.1-dev
[#42976] - [5.1] Fix fatal error during Joomla update
- Closed
- 8 Mar 2024
- Medium
- Build: 5.1-dev
- # 42976
- Diff
- joomdonation:fix_update_fatal_error
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
As of right now, update to Joomla 5.1 nightly build package will get fatal error. It is because the code for delete folders using Path::clean method which is not available for using. You can read the discussion at #42971 to understand more if needed
As the list of folders are provided by us, so it is clean and trusted, we can remove Path::clean call here. I also made some minor clean up to the code, too.
Testing Instructions
- Uses Joomla 5
- Change settings of Joomla update component. Set Update Channel to Custom URL, and set Custom URL to https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42976/downloads/74420/pr_list.xml
Actual result BEFORE applying this Pull Request
If you update your site to Joomla nightly build package, you will get fatal error
Expected result AFTER applying this Pull Request
No error updating to package generated by this PR.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-08 06:19:54 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
PR-5.1-dev
|
||
Closing because the changes here are all included in other PR #42978 .