PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
7 Mar 2024

Pull Request for Issue # .

Summary of Changes

As of right now, update to Joomla 5.1 nightly build package will get fatal error. It is because the code for delete folders using Path::clean method which is not available for using. You can read the discussion at #42971 to understand more if needed

As the list of folders are provided by us, so it is clean and trusted, we can remove Path::clean call here. I also made some minor clean up to the code, too.

Testing Instructions

Actual result BEFORE applying this Pull Request

If you update your site to Joomla nightly build package, you will get fatal error

Expected result AFTER applying this Pull Request

No error updating to package generated by this PR.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomdonation joomdonation - open - 7 Mar 2024
avatar joomdonation joomdonation - change - 7 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2024
Category Administration com_admin
avatar joomdonation joomdonation - change - 7 Mar 2024
The description was changed
avatar joomdonation joomdonation - edited - 7 Mar 2024
avatar joomdonation joomdonation - change - 8 Mar 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-03-08 06:19:54
Closed_By joomdonation
Labels Added: PR-5.1-dev
avatar joomdonation
joomdonation - comment - 8 Mar 2024

Closing because the changes here are all included in other PR #42978 .

avatar joomdonation joomdonation - close - 8 Mar 2024

Add a Comment

Login with GitHub to post a comment