[#42978] - [5.1] Aliasing Filesystem classes for installation, updating script.php
- Fixed in Code Base
- 10 Mar 2024
- Medium
- Build: 5.1-dev
- # 42978
- Diff
- Hackwar:5.1-install-file
User tests: Successful: Unsuccessful:
Pull Request for Issue #42971 .
Summary of Changes
With the refactoring of system calls to the framework filesystem package, I introduced a new error when updating since at the time when script.php is run, the framework class ist not there. This PR changes the namespace of the classes in the finalisation.php to reflect first the framework filesystem package and then to alias those classes for the CMS filesystem package. It also fixes the code in script.php to use the framework code consistently. That should hopefully fix the issue and be compatible pretty much regardless from where to where we upgrade.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_joomlaupdate |
Could you please also delete the two elements here https://github.com/joomla/joomla-cms/blob/5.0-dev/administrator/components/com_admin/script.php#L575-L576 as I did in in my original PR #42976 ? Thanks !
| Labels |
Added:
Release Blocker
bug
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 5f35b5d
Tested update from both Joomla 4 and Joomla 5 to the update package provided by this PR, it worked well, no error anymore
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42978.
I have tested this item ✅ successfully on 5f35b5dTested update from both Joomla 4 and Joomla 5 to the update package provided by this PR, it worked well, no error anymore
@joomdonation Have you used Windows or a Linux as server? Would be good if we get another tester using what you haven't used.
@brianteeman Does your thumbs down reaction on the description of this PR still apply, or is it obsolete after the recent changes? If obsolete: Please remove. If not obsolete: Would you like to comment on the reasons? Thanks in advance.
@richard67 I tested using Windows. I also did a careful code review.
@richard67 I tested using Windows. I also did a careful code review.
@joomdonation Thanks. I did also a careful code review. PR is ok for me. Will see if I can find time to test on Linux.
I have tested this item ✅ successfully on 5f35b5d
I've tested both live update and upload & update from 4.4.3 and 5.0.3 to the custom update URL or update package created by drone for this PR.
I've also tested that updating from 5.1.0-beta 1 with the PR applied before the update works.
Finally I've done a code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42978.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42978.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-10 02:53:28 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
Thx
@Hackwar Does PR #42976 still make sense together with this one here? I assume yes, but maybe you know more.
Update: Ah, I just see this PR contains also the changes of the other one.