Feeling Lucky
RTC
PR-5.1-dev
[#42899] - [5.1] Convert mod_tags_popular to service provider
- Fixed in Code Base
- 28 Feb 2024
- Medium
- Build: 5.1-dev
- # 42899
- Diff
- joomlaweby:mod_tags_popular
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the popular tags site module to service provider.
Testing Instructions
- Make sure you have site module mod_tags_popular published
- Add some tags and assign them to several content items
- You should see module output
- You should not see module output, when all tags are unpublished/deleted and "Show No results text" module setting is disabled.
- You should see module output with no results message, when all tags are unpublished/deleted and "Show No results text" module setting is enabled.
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
PR-5.1-dev
|
||
viocassel
- comment
- 27 Feb 2024
I have tested this item ✅ successfully on 46f56aa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42899.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 27 Feb 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42899.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-28 00:07:10 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 28 Feb 2024
Thank you @joomlaweby and also to the testers @fgsw @viocassel
I have tested this item ✅ successfully on 46f56aa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42899.