[#42900] - [5.1] TUF Code Cleanup
- Fixed in Code Base
- 14 Mar 2024
- Medium
- Build: 5.1-dev
- # 42900
- Diff
- wilsonge:tuf/fix-stuff
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Various minor reworkings to the TUF code as below
Summary of Changes
- Removes the extra HTTP Factory - it serves no purpose. Whilst we don't implement PSR-18 yet it shows the type of object to be passed around which is a created HTTP client - not the factory for it: https://www.php-fig.org/psr/psr-18/
- Rework constructor args - db is now required (it already existed in one of the two instantiating classes anyhow and we call Factory::getDbo() already in the other), makes application a required parameter (we were statically grabbing it in the class - which shouldn't be the case for new classes).
- Fixes the constructor doc block
Testing Instructions
Check all TUF functionality from #42799 continues to work with no changes. New code is slightly easier to maintain and read.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
PR-5.1-dev
|
||
| Labels |
Added:
Release Blocker
|
||
hopefully i've done it in a right way
but it works for me now
I have tested this item ✅ successfully on 0eda369
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42900.
I have tested this item ✅ successfully on 0eda369
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42900.
Before this PR my test server without curl would fail to check for updates etc
With this PR there was no problem
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42900.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42900.
| Labels |
Added:
RTC
|
||
no, cause
sometimes drone failure are ..... ?
not on my local
@richard67 i mean sometimes you got drone failing for timoeout and... something else ..,etc
thanks for fixing it
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-14 15:22:14 |
| Closed_By | ⇒ | LadySolveig |
Thanks to all involved ?
@SniperSister would be good to understand why we're forcing curl to make the http requests rather than the any of the 3 options the server might support