[#42898] - [5.1] Convert mod_tags_similar to service provider
- Fixed in Code Base
- 28 Feb 2024
- Medium
- Build: 5.1-dev
- # 42898
- Diff
- joomlaweby:mod_tags_similar
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the tags similar site module to service provider.
Testing Instructions
- Make sure you have site module mod_tags_similar published
- Add some tags and assign them to several content items
- You should see module output on content items, which have at least 1 tag assigned and this tag is assigned also on another content items.
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item ✅ successfully on ab215d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898.
What means "Service Provider"?
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898.
What means "Service Provider"?
@fgsw Simple explanation is, that it is a new way, how extensions in Joomla works since 4.0. I found more technical explanation here: https://docs.joomla.org/J4.x:Dependency_Injection_in_Joomla_4#Providers
For example in mod_articles_latest extension it is this file: https://github.com/joomla/joomla-cms/blob/5.1-dev/modules/mod_articles_latest/services/provider.php
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-28 00:02:14 |
| Closed_By | ⇒ | LadySolveig |
Thank you @joomlaweby and also for testing @viocassel and @fgsw
I have tested this item ✅ successfully on ab215d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898.