Feeling Lucky
RTC
PR-5.1-dev
[#42868] - [5.1] Use local $container instead of getting from Factory
- Fixed in Code Base
- 26 Feb 2024
- Medium
- Build: 5.1-dev
- # 42868
- Diff
- joomdonation:code_improvement_system_schemaorg
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Just a small code improvement to System - Schema.org plugin. We can use the container from local variable $container to get database service instead of calling Factory::getContainer() to get the container.
Testing Instructions
- Code review should be enough
- For human testing :
- Use Joomla 5.1
- Add or edit an article, select one Schema Type for that article in Schema tab and enter data, save it and make sure no error happens.
Actual result BEFORE applying this Pull Request
Works !
Expected result AFTER applying this Pull Request
Works !
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
alikon
- comment
- 24 Feb 2024
I have tested this item ✅ successfully on 7bd0563
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42868.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 24 Feb 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42868.
| Title |
|
||||||
| Labels |
Added:
RTC
PR-5.1-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-26 23:14:30 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 26 Feb 2024
Thank you @joomdonation and also for testing @Fedik @alikon
I have tested this item ✅ successfully on 7bd0563
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42868.