[#42869] - [4.4] Fix Banners application crashes
- Fixed in Code Base
- 28 Feb 2024
- Medium
- Build: 4.4-dev
- # 42869
- Diff
- joomdonation:fix_banner_helper
User tests: Successful: Unsuccessful:
Pull Request for Issue #42841.
Summary of Changes
The current code in BannerHelper classs bind a Joomla\CMS\Date\Date object to :date parameter and could cause application crashes in some environments as reported in the issue. This PR changes code so that the parameter is bound by a string in Datetime format instead (same with the code in other places in Joomla). I also rename the variable to $nowDate to imply that this is current date time (also, same with similar codes use in other places in Joomla)
Testing Instructions
- Use Joomla 4.4
- Apply patch
- Access to Banners Management screen from administrator area of your site
Actual result BEFORE applying this Pull Request
Sometime application crashes
Expected result AFTER applying this Pull Request
Always works, no crashes anymore.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
I have tested this item ✅ successfully on 183b562
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42869.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42869.
| Labels |
Added:
RTC
PR-4.4-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-28 11:12:32 |
| Closed_By | ⇒ | laoneo |
Thanks!
I have tested this item ✅ successfully on 183b562
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42869.