[#42867] - [5.2] Remove useless string
- Closed
- 24 Apr 2024
- Medium
- Build: 5.0-dev
- # 42867
- Diff
- brianteeman:scheme
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
The code loads a joomla language string with two params The text string ignores the first param and just outputs the second with no additional data
In other words both the language string and the first param can be removed without any impact.
Pull Request for Issue #41233
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
I have tested this item ✅ successfully on a9cb0a7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42867.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Language Change
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42867.
| Labels |
Added:
RTC
|
||
is there a reason that this RTC pr is not being merged?
| Title |
|
||||||
| Labels |
Added:
PR-5.1-dev
Removed: PR-5.0-dev |
||||||
@bembelimen any reason this to keep the language string? Don't think so but just want to ask if any language override can make sense here.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
Closed due to lack of interest or response from release leads
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-24 19:09:06 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
Feature
PR-5.2-dev
|
||
I have tested this item ✅ successfully on a9cb0a7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42867.