[#42866] - [5.1] Convert mod_sampledata to service provider
- Fixed in Code Base
- 24 Feb 2024
- Medium
- Build: 5.1-dev
- # 42866
- Diff
- joomlaweby:mod_sampledata
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the sample data administrator module to service provider.
Testing Instructions
- Make sure you have administrator module mod_sampledata published
- You should see module output
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
How to get 'Testing Sampe Data'?
Default installation (cloudaccess) only 2 plugins:
@fgsw I suppose Testing sample data plugin is available only when Joomla installation is done from cloned github repository, but not from released package. Probably this line is removing it during build :
Line 151 in 7c6e2ca
mod_sampledata is shipped with every release of Joomla.
There are three plugins that are displayed in the module
- Blog
- Multilingual
- Testing
Of these three it is the third one (testing) that is not shipped with released versions of Joomla. The other two are always shipped with Joomla and enabled by default with the module which displays them on the home page of the admin
As this PR is only for the module you do not need all three plugins in order to test
I have tested this item ✅ successfully on 1ead3d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42866.
I have tested this item ✅ successfully on 1ead3d6
Thanks for explanations.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42866.
I have tested this item ✅ successfully on 1ead3d6
Module output shown before as well as after.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42866.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42866.
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on 06868d6
It's OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42866.
I have tested this item ✅ successfully on 06868d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42866.
| Labels |
Added:
PR-5.1-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-24 16:54:55 |
| Closed_By | ⇒ | LadySolveig |
How to get 'Testing Sampe Data'?
Default installation (cloudaccess) only 2 plugins: