Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42803] - [4] Module 'Feed Display': deprecated Notice

RTC PHP 8.x PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
13 Feb 2024

Pull Request for Issue #42793 .

Summary of Changes

skip if publishDate is null

Testing Instructions

see #42793

Actual result BEFORE applying this Pull Request

deprecated Notice

Expected result AFTER applying this Pull Request

No deprecated Notice

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 13 Feb 2024
avatar alikon alikon - change - 13 Feb 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2024
Category ⇒ Modules Administration Front End
avatar ChristineWk ChristineWk - test_item - 17 Feb 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 17 Feb 2024

I have tested this item ✅ successfully on bbe656d

J 4.4.3-dev

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

avatar ceford
ceford - comment - 20 Feb 2024

I came across a problem testing this PR: with an Atom feed there is still a deprecated notice with the patch applied. See this Forum discussion: https://forum.joomla.org/viewtopic.php?f=834&t=1007409&p=3715335#p3715335 and perhaps try this feed url: https://www.youtube.com/feeds/videos.xml?channel_id=UCbayot0NQ0HWeCs9J8Mx7fA

I realise fixing an Atom feed may be considered a different issue to fixing an RSS feed. But that would be lost on the end user.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

avatar ceford
ceford - comment - 20 Feb 2024

Oops - I tested with J5 but I think the comment stands.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

avatar fgsw fgsw - test_item - 21 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 21 Feb 2024

I have tested this item ✅ successfully on bbe656d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

avatar richard67 richard67 - change - 21 Feb 2024
Status Pending ⇒ Ready to Commit
Labels Added: PHP 8.x PR-4.4-dev
avatar richard67
richard67 - comment - 21 Feb 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

avatar alikon
alikon - comment - 21 Feb 2024

@ceford is right
just got the same result with https://www.youtube.com/feeds/videos.xml?channel_id=UCbayot0NQ0HWeCs9J8Mx7fA
image

avatar alikon alikon - change - 22 Feb 2024
Labels Added: RTC
avatar alikon alikon - change - 22 Feb 2024
Labels Removed: RTC
avatar alikon
alikon - comment - 22 Feb 2024

@ceford should be fixed now the atom feed too

avatar MacJoom MacJoom - change - 22 Feb 2024
Labels Added: RTC
avatar MacJoom MacJoom - change - 22 Feb 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-02-22 14:17:21
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 22 Feb 2024
avatar MacJoom MacJoom - merge - 22 Feb 2024
avatar MacJoom
MacJoom - comment - 22 Feb 2024

Thank you!

Add a Comment

Login with GitHub to post a comment