[#42802] - [4.4] Fixing non-SEF URL in feed output
- Fixed in Code Base
- 4 Mar 2024
- Medium
- Build: 5.0-dev
- # 42802
- Diff
- Hackwar:5.0-feed-url
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #39775.
Summary of Changes
When Joomla is installed in a subdirectory and URLs are set to be completely non-SEF, the URLs in a feed output are wrong. Specifically, the path to the root of Joomla is doubled, for example https://domain.tld/subdir/subdir/index.php instead of just https://domain.tld/subdir/index.php
It works fine with SEF URLs enabled.
Testing Instructions
- Install Joomla in a subdirectory and disable all SEF URL options
- Go to a category view and look at the feed URL in the header.
- Download the feed and look into the output.
Actual result BEFORE applying this Pull Request
The link in for example <atom:link rel="self" type="application/rss+xml" is wrong
Expected result AFTER applying this Pull Request
The link in for example <atom:link rel="self" type="application/rss+xml" is correct.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Numerous of my PRs for 4.4 have been declared as new features even though they were bugfixes and rejected, so I stopped creating PRs for 4.4.
I'm very well aware of that, but my time is not free and if I create bugfixes like #42693 and get told that this PHP error is not something which will be fixed in 4.4, then I'll stop creating fixes for 4.4. I don't have to waste my time and the time of other contributors by creating a PR for 4.4, organising people to test that PR, them investing the time to actually test, and then be told that an obvious bug is not a bug and that the PR is going to be rejected. So I'm skipping that whole part and create PRs against the next branch up.
I have tested this item ✅ successfully on fda45a7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
I have tested this item ✅ successfully on fda45a7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
| Title |
|
||||||
| Category | Front End Plugins | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Labels |
Added:
Unit/System Tests
PBF
bug
PR-5.0-dev
PR-4.4-dev
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Front End Plugins |
I recreated the PR with 4.4-dev as base branch. The code is identical. Do we need new tests?
| Labels |
Removed:
Unit/System Tests
|
||
@Globulopolis @viocassel Could you test this PR again on 4.4.x? Thanks in advance.
I have tested this item ✅ successfully on b3ef272
?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
I have not tested this item.
@den1ska07 If you submit a test result you have to select the right result before submitting.
I have tested this item ✅ successfully on b3ef272
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
I have tested this item ✅ successfully on b3ef272
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-04 15:58:27 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
Removed: PR-5.0-dev |
||
Thanks!
@Hackwar Is there a reason why not fixing it for 4.4-dev?