RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
13 Feb 2024

Pull Request for Issue #42796 .

Summary of Changes

define 6the autocomplete

Testing Instructions

  1. Install the 5 nightly build,
  2. Publish the plugin "Multi-factor Authentication - Fixed Code",
  3. Create a fixed code MFA method and try to login at the front.

Actual result BEFORE applying this Pull Request

0 Property autocomplete not found in Joomla\Component\Users\Administrator\DataShape\DataShapeObject

Expected result AFTER applying this Pull Request

able to login with mfa fixed code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 13 Feb 2024
avatar alikon alikon - change - 13 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2024
Category Administration com_users
avatar Kostelano Kostelano - test_item - 13 Feb 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 13 Feb 2024

I have tested this item ✅ successfully on 349682e

Everything is fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42804.

avatar Quy Quy - change - 13 Feb 2024
Labels Added: PR-5.0-dev
avatar Quy Quy - test_item - 13 Feb 2024 - Tested successfully
avatar Quy
Quy - comment - 13 Feb 2024

I have tested this item ✅ successfully on c986c5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42804.

avatar Quy Quy - alter_testresult - 13 Feb 2024 - Kostelano: Tested successfully
avatar Quy Quy - change - 13 Feb 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42804.

avatar richard67
richard67 - comment - 14 Feb 2024

@alikon Do you know if we have the same issue also in 4.4?

avatar alikon
alikon - comment - 14 Feb 2024

dunno i'll check later

avatar alikon
alikon - comment - 14 Feb 2024

doesn't happen on 4.4 if i checked correctly
image

avatar richard67
richard67 - comment - 14 Feb 2024

@alikon You are right. The PR #38854 which added that code line was once made for 4.2, but then it was merged into 5.0-dev and not into 4.4-dev because it was counted as a new feature at that time: #38854 (comment) . Thanks for checking.

avatar Quy Quy - change - 22 Feb 2024
Labels Added: RTC
avatar bembelimen bembelimen - change - 17 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-17 14:55:26
Closed_By bembelimen
Labels Added: PR-5.1-dev
Removed: PR-5.0-dev
avatar bembelimen bembelimen - close - 17 Mar 2024
avatar bembelimen bembelimen - merge - 17 Mar 2024
avatar bembelimen
bembelimen - comment - 17 Mar 2024

Thx

Add a Comment

Login with GitHub to post a comment