Feeling Lucky
Feature
RTC
NPM Resource Changed
PR-5.2-dev
[#42798] - [5.2] Other JS improvements
- Fixed in Code Base
- 21 May 2024
- Medium
- Build: 5.1-dev
- # 42798
- Diff
- C-Lodder:other-js
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Convert site template JS to ES6
- Remove
[].slice.call()calls where possible. - Other minor improvements
Testing Instructions
- Ensure the front-end MetisMenu is working properly.
- Code review @dgrammatiko @Fedik
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
HLeithner
- comment
- 24 Apr 2024
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
Fedik
- comment
- 24 Apr 2024
I have tested this item ✅ successfully on 559efc8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42798.
viocassel
- comment
- 19 May 2024
I have tested this item ✅ successfully on 559efc8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42798.
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.1-dev
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 20 May 2024
RTC as the previous human tests are still valid. The commit which invalidated the test count was just a branch update with a small easy conflict which I've resolved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42798.
C-Lodder
- comment
- 21 May 2024
Thanks @richard67
| Labels |
Added:
RTC
Removed: PR-5.1-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-21 12:32:53 |
| Closed_By | ⇒ | pe7er |
@dgrammatiko @Fedik can you have a look?