Feeling Lucky
RTC
NPM Resource Changed
PR-5.2-dev
[#42797] - [5.2] Minor cleanup for plugins JS
- Fixed in Code Base
- 21 May 2024
- Medium
- Build: 5.1-dev
- # 42797
- Diff
- C-Lodder:plugins-js
User tests: Successful: Unsuccessful:
Summary of Changes
As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of forEach can iterater over a NodeList.
Also includes some other minor tweaks.
Testing Instructions
Code review @dgrammatiko @Fedik
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
| Title |
|
||||||
Fedik
- comment
- 24 Apr 2024
I have tested this item ✅ successfully on 0a28f6e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42797.
viocassel
- comment
- 20 May 2024
I have tested this item ✅ successfully on 0a28f6e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42797.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 20 May 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42797.
| Labels |
Added:
RTC
PR-5.2-dev
Removed: PR-5.1-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-21 11:28:02 |
| Closed_By | ⇒ | pe7er |
This pull request has been automatically rebased to 5.2-dev.