Thanks!
Only thing is left is to fix code style :)
https://ci.joomla.org/joomla/joomla-cms/73378/1/7
It looks like you mixed something with an indents

Thanks! Only thing is left is to fix code style :) https://ci.joomla.org/joomla/joomla-cms/73378/1/7 It looks like you mixed something with an indents

Well, after an embarrassing number of commits, I think I've made PHPCS happy!

For some reason, this was telling me I had no linting issues:
./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .

Although I'm going to assume I didn't successfully configure the Joomla Coding Standards for PHPCS & VS Code correctly... I'll figure that out later.

Thank you all for your patience!

@adamchaboryk I have made a PR to your branch with a couple more fixes adamchaboryk#1

@adamchaboryk I made a couple changes and rearrangements to address the backward compatibility, in case when someone use this assets outside of plugin adamchaboryk#2
Restored es5 asset, wich basicaly a dummy, and will be removed later with Joomla 6.

I have tested this item ✅ successfully on 9144751

Works good, thanks!

@brianteeman please run the test, then we can complete here, I think

I have tested this item ? unsuccessfully on 9144751

In the plugin options if you set "Additional Checks Always On" I would expect that they are always on no matter what the individual settings. Then those checks take place.

Always check for Form Labels, Contrast, Links (Advanced) by default. Enabling this option will visually hide the toggle switches in the Settings panel.

But that is not the case. I dont know if its my misunderstanding of the setting or there is a code error.

The only way to check links with the individua settings visually hidden is if you configure it as follows

In the plugin options if you set "Additional Checks Always On" I would expect that they are always on no matter what the individual settings. Then those checks take place.

This setting just hides the switches/toggles under Sa11y's "Settings" pane. The other toggles in admin settings can turn off those specific checks entirely.

Scenario: Someone may want to check page for all toggleable checks by default, but there website doesn't have any forms, so they turn off the specific "Form Labels" check in Joomla admin settings.

Maybe we can brainstorm a new label for "Additional Checks Always On"...

That is not my understanding of the help text which is in two parts

Always check for Form Labels, Contrast, Links (Advanced) by default.

implies these three checks will always take place

Enabling this option will visually hide the toggle switches in the Settings panel.

implies that the settings are not exposed to the user.

From my understanding of the behaviour that takes place then the help text should be

Enabling this option will visually hide the toggle switches for Form Labels, Contrast, Links (Advanced) in the Settings panel.

Enabling this option will visually hide the toggle switches for Form Labels, Contrast, Links (Advanced) in the Settings panel.

Works for me, makes more sense.

A release lead needs to decide if it is ok to delete all these unused strings r if we must follow previous policy that they should be deprecated instead

@adamchaboryk I made another PR for string deprecation adamchaboryk#3
Unfortunatley we cannot just delete them

will give it a more detailed test tomottow but it looks good to me

I have tested this item ✅ successfully on 9144751

Thanks Adam

r2c

Added the language strings deprecation also to to the migration section in the documentation

joomla/Manual#223

great -= thanks all

Thank you so much @adamchaboryk for your work and for taking care on the implementation into Joomla and this very nice new features ?
I really enjoyed seeing this great collaboration - thanks to everyone for being involved @Fedik @brianteeman @Quy @dgrammatiko

Thank you, Martina! I'm super excited for 5.1! I'm also very grateful for all the support and guidance from everyone. Looking forward to future collaborations!