Feeling Lucky
RTC
NPM Resource Changed
PR-5.1-dev
[#42778] - [5.1] Minor cleanup for component JS
- Fixed in Code Base
- 18 Mar 2024
- Medium
- Build: 5.1-dev
- # 42778
- Diff
- C-Lodder:js-improvements
User tests: Successful: Unsuccessful:
Summary of Changes
As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of forEach can iterater over a NodeList.
Also includes some other minor tweaks.
Happy to work on the remaining JS
Testing Instructions
Code review @dgrammatiko @Fedik
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
dgrammatiko
- comment
- 11 Feb 2024
I have tested this item ✅ successfully on 29f887d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778.
Fedik
- comment
- 12 Feb 2024
I have tested this item ✅ successfully on 29f887d
Looks good on review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778.
| Status | Pending | ⇒ | Ready to Commit |
Fedik
- comment
- 12 Feb 2024
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-18 21:29:05 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 18 Mar 2024
Thank you @C-Lodder and also for review and testing @dgrammatiko @Fedik
@dgrammatiko
I'll do that in a separate PR, as it will probably involve more than just a code review.