In light mode 'Clear'-Button not visible:

Is this the intended color? The light version has a different color matching.

Menu --> Privacy Dashboard, violation for both themes.

Different color separator.

Wherever the “loading” indicator of something is used, the Joomla icon looks like this. I’m not sure if this is related to this PR, but I’ll report it anyway.

Fields with the disabled="disabled" attribute are not highlighted in the dark theme.

I have tested this item ✅ successfully on e5fc19a

I have tested this item ✅ successfully on e5fc19a

Small changes in colors

I have tested this item ? unsuccessfully on e5fc19a

Switching Firefox to dark mode immediately changes Joomla to dark mode too. With or without this Patch

Colors doesn't change after applying patch.

I have tested this item ? unsuccessfully on e5fc19a

Cannot reproduce problem before applying patch

I dragged the installation extension with the mouse. And I saw a white standby setup screen.
Quite obviously there should be a dark screen.

Probably there should be a black translucent one here

Wherever the “loading” indicator of something is used, the Joomla icon looks like this. I’m not sure if this is related to this PR, but I’ll report it anyway.

@Kostelano See #42903

new:

old:

Colleagues, I understand that a lot of work has already been done, it turned out to be many times more work than expected. And a huge thank @MacJoom .

I want to suggest making the links a little lighter.
The old color is annoying because they differ too much in color from the main text.
I'll give you an example. For example, if we have a text that is bright green and bright red, then when working with the text, we try to relax so that we focus only on the idea of the text. So the eyes focus only on the bright red color, or on the bright green color. Constantly switching the focus of attention from colors is annoying.
There is a similar situation here, the eyes have to change the focus of the text color when reading.
I'm not insisting. But when using the site, you will eventually feel a mild strain in your eyes.
It resembles the tension of text with a translucent color.
Maybe we'll put this amendment in the next PR?

Focus on the white text and then on the links, you will feel that the white and light blue text are perceived as one. And dark blue links are perceived separately, try to check the focus of attention on the text with links.

Example blue link color: #6fbfdb

new: old:

Colleagues, I understand that a lot of work has already been done, it turned out to be many times more work than expected. And a huge thank @MacJoom .

I want to suggest making the links a little lighter. The old color is annoying because they differ too much in color from the main text. I'll give you an example. For example, if we have a text that is bright green and bright red, then when working with the text, we try to relax so that we focus only on the idea of the text. So the eyes focus only on the bright red color, or on the bright green color. Constantly switching the focus of attention from colors is annoying. There is a similar situation here, the eyes have to change the focus of the text color when reading. I'm not insisting. But when using the site, you will eventually feel a mild strain in your eyes. It resembles the tension of text with a translucent color. Maybe we'll put this amendment in the next PR?

Focus on the white text and then on the links, you will feel that the white and light blue text are perceived as one. And dark blue links are perceived separately, try to check the focus of attention on the text with links.

Example blue link color: #6fbfdb

The color chosen for the links is selected to work for white on linkcolor and on linkcolor on white. So we have only one variable. Another color means way more work and is prohibiting this PR to be ready any time soon

@coolcat-creations
Do you want to say that in a dark theme and in a white theme, the color of the links will be the same, without changes?

@coolcat-creations

Do you want to say that in a dark theme and in a white theme, the color of the links will be the same, without changes?

No I was talking only about the dark theme

No I was talking only about the dark theme

I didn't know that the dark theme has a white background for the text.
Sorry. Alas.
How deep is the edit to make. I would suggest that you definitely plan to add it after making this PR.
Have the participants already discussed the plans for a new template based on cassiopeia?
I hope you will agree that my suggestion of link colors is important.

Sorry that was a mistake in my text, i meant link color on dark and white on link color. Cassiopeia is totally unrelated to the backend template.

@LadySolveig i think all the outstanding issues are fixed can we merge and create afterwards separate PRs if something comes up?

@coolcat-creations @MacJoom Please remove the block of testing code in the template

Already reverted actually

Already reverted actually

Not sure where its reverted because it is still present in this pr

Already reverted actually

Not sure where its reverted because it is still present in this pr

I only can make PRs to the other PR I cant do a separate PR because this is not merged yet, so we always need to wait until its resolved in the main. Thats also the reason why I am begging to merge this so fixes can be done in smaller PRs

I only can make PRs to the other PR

Of course you can - you make it to MacJoom:dark-mode-5.1-dev

Which I did, thats what I am saying :-)

so just ask @MacJoom to merge it or to gicve you access on his repo to merge it. That shouldnt be a reason to merge a pr here that is known not to be ready

The new template screenshots in this PR are not used as they are jpg but the code is looking for png

I did already and he did, I only told you that Its reverted already. Still standing by my point that it would be easier if we have smaller PRs this is hard to work on

Please fix file conflict.

Closed in favour of #42986