RTC NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
4 Feb 2024

Summary of Changes

This PR fixes error validation on a "User" field when a user is selected.

Testing Instructions

  1. Got to administrator/index.php?option=com_messages&view=messages
  2. Click "New"
  3. Focus on the "Recipient" user input field
  4. Focus away from the "Recipient" user input field (you'll see a red error message)
  5. Select a user

Actual result BEFORE applying this Pull Request

Field remained red with the error message

Expected result AFTER applying this Pull Request

Error message is removed and field border turns green

avatar C-Lodder C-Lodder - open - 4 Feb 2024
avatar C-Lodder C-Lodder - change - 4 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2024
Category JavaScript Repository NPM Change
avatar dgrammatiko
dgrammatiko - comment - 4 Feb 2024

I wouldn't add another listener into the validate.js.
FWIW you can fix this issue by replacing this

dialog.addEventListener('joomla-dialog:close', () => {
window.removeEventListener('message', msgListener);
dialog.destroy();
this.dialog = null;
});

with this:

    dialog.addEventListener('joomla-dialog:close', () => {
      window.removeEventListener('message', msgListener);
      dialog.destroy();
      this.dialog = null;
      this.inputName.focus();
      this.buttonSelect.focus();
    });

Basically it's a focus delegation problem...

avatar fgsw fgsw - test_item - 5 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 5 Feb 2024

I have tested this item ✅ successfully on 57babee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

avatar C-Lodder C-Lodder - change - 5 Feb 2024
Labels Added: NPM Resource Changed PR-5.1-dev
avatar C-Lodder C-Lodder - change - 5 Feb 2024
The description was changed
avatar C-Lodder C-Lodder - edited - 5 Feb 2024
avatar viocassel viocassel - test_item - 5 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 5 Feb 2024

I have tested this item ✅ successfully on 0dabe82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

avatar fgsw fgsw - test_item - 6 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 6 Feb 2024

I have tested this item ✅ successfully on 0dabe82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

avatar Quy Quy - change - 6 Feb 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

avatar Quy Quy - change - 6 Feb 2024
Labels Added: RTC
avatar crimle crimle - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on dc0db7f

Pressing the button {Apply Patch] results in error message
There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

avatar Nuyonuyonoina
Nuyonuyonoina - comment - 24 Feb 2024

"Apply patch" button doesn't work. Error message is "There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."

avatar eddiekonczal eddiekonczal - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar eddiekonczal
eddiekonczal - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on dc0db7f

When I try to install the patch, I get this error:

"There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

avatar richard67
richard67 - comment - 25 Feb 2024

@crimle @Nuyonuyonoina @eddiekonczal I will reset the negative test results as they are not caused by this PR. The PR modifies an NPM dependency, which can be seen by the label "NPM Resource Changed". Such PRs can't be tested with Patchtester, they require either a development environment with composer and NPM, or they need to be applied by using the packages created by drone, which can be found in the "Downloads" section of the integration checks at the bottom of the PR.

avatar richard67 richard67 - alter_testresult - 25 Feb 2024 - crimle: Not tested
avatar richard67 richard67 - alter_testresult - 25 Feb 2024 - eddiekonczal: Not tested
avatar richard67 richard67 - alter_testresult - 25 Feb 2024 - viocassel: Tested successfully
avatar richard67 richard67 - alter_testresult - 25 Feb 2024 - fgsw: Tested successfully
avatar bembelimen bembelimen - change - 25 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-25 22:19:34
Closed_By bembelimen
avatar bembelimen bembelimen - close - 25 Feb 2024
avatar bembelimen bembelimen - merge - 25 Feb 2024
avatar bembelimen
bembelimen - comment - 25 Feb 2024

Thx

Add a Comment

Login with GitHub to post a comment