[#42726] - [5.1] Replace deprecated substr() with substring()
- Fixed in Code Base
- 27 Feb 2024
- Medium
- Build: 5.1-dev
- # 42726
- Diff
- C-Lodder:substr
User tests: Successful: Unsuccessful:
Summary of Changes
Javascript's substr() method has been deprecated for ages now (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) and this PR replaces it with substring()
Testing Instructions
- Inline Help should still work as expected.
- Add a simple colour field to any XML file (
<field name="foo" type="color" label="Test" control="simple" />) and ensure the field works as expected. - Ensure toggling the TineMCE presets within the Plugin Manager still works as expected.
I was unable to test the calendar changes as the code has no comments to assist developers, so this might need to be a code review instead.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Language & Strings |
I have tested this item ✅ successfully on a68b18a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726.
I have tested this item ✅ successfully on a68b18a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PBF
Language Change
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726.
I have not tested this item.
Not testable...
Using Download / Details at the bottom of the Patch page,
https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42726/downloads/73221 you receive an error message:
Not Found
The requested URL was not found on this server.
Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726.
@exlemor Possibly the downloads are not available anymore because some time after a PR has been updated last time, the downloads are deleted. As the PR already has 2 good tests I have set it to RTC (ready to commit), so it doesn't need any more tests. But I will trigger a new build of the testing packages now by updating the branch so a bit later new downloads will be available.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-27 16:30:10 |
| Closed_By | ⇒ | LadySolveig |
Thank you @C-Lodder and also to the testers @ceford @steffans and @viocassel
I have tested this item ✅ successfully on a68b18a
All checked - calendar field in Article edit worked normally.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726.