RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
29 Jan 2024

Pull Request for Issue #42320.

Summary of Changes

When an articles intro image contains a blank space, our code to search for related files in the media folder strips the whole image from the output of the search results. This change prevents this. The images of a search result should be the exact images, not the potential compressed files or similar from the media folder.

Testing Instructions

  1. Add an image with a space in the filename in the /images folder
  2. Edit an article and set the intro image to that image. By saving, the index should be updated.
  3. Set the image to be displayed in the search results in the configuration of either the search menu item or in the smart search global configuration.
  4. Search for the article

Actual result BEFORE applying this Pull Request

The article is displayed without the image.

Expected result AFTER applying this Pull Request

The article is displayed WITH the image.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 29 Jan 2024
avatar Hackwar Hackwar - change - 29 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2024
Category Front End com_finder
avatar Quy Quy - test_item - 30 Jan 2024 - Tested successfully
avatar Quy
Quy - comment - 30 Jan 2024

I have tested this item ✅ successfully on 4127a34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42725.

avatar fgsw fgsw - test_item - 30 Jan 2024 - Tested successfully
avatar fgsw
fgsw - comment - 30 Jan 2024

I have tested this item ✅ successfully on 4127a34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42725.

avatar alikon alikon - change - 30 Jan 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 30 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42725.

avatar Quy Quy - change - 30 Jan 2024
Labels Added: RTC bug PR-4.4-dev
avatar MacJoom MacJoom - change - 5 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-05 21:49:24
Closed_By MacJoom
avatar MacJoom MacJoom - close - 5 Feb 2024
avatar MacJoom MacJoom - merge - 5 Feb 2024
avatar MacJoom
MacJoom - comment - 5 Feb 2024

Thank you!

Add a Comment

Login with GitHub to post a comment