[#42614] - Update SiteRouter.php - check $force_ssl non type safe
- Closed
- 5 Jan 2024
- Medium
- Build: 4.4-dev
- # 42614
- Diff
- sba:patch-3
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
When updateing joomla from joomla 3 to joomla 4.4 the value in cofiguration.php is still saved with public $force_ssl = '2' instead of public $force_ssl = 2. If set as string, the force_ssl setting has no effect, the redirection to https is not working.
Furthermore, the cli command '/cli/joomla.php config:set force_ssl=2' also sets the configuration.php to public $force_ssl = '2'.
The change should have no further effect, everywhere else in the code force_ssl is checked non type-safe.
Testing Instructions
Joomla 4.4.1
Run '/cli/joomla.php config:set force_ssl=2' and you will get public $force_ssl = '2'; in configuration.php
Actual result BEFORE applying this Pull Request
redirection to https is not wotking, site loads with http://...
Expected result AFTER applying this Pull Request
Force SSL ist working, when opening with http://... the site is redirected to https://...
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-05 12:44:35 |
| Closed_By | ⇒ | sba | |
| Labels |
Added:
Unit/System Tests
PR-4.4-dev
|
||
I'm guessing that you actually wanted to target the 5.0-dev branch?