[#42615] - Update SiteRouter.php - check $force_ssl non type safe
- Fixed in Code Base
- 10 Jan 2024
- Medium
- Build: 4.4-dev
- # 42615
- Diff
- sba:patch-4
User tests: Successful: Unsuccessful:
Summary of Changes
When updateing joomla from joomla 3 to joomla 4.4 the value in cofiguration.php is still saved with public $force_ssl = '2' instead of public $force_ssl = 2. If set as string, the force_ssl setting has no effect, the redirection to https is not working.
Furthermore, the cli command '/cli/joomla.php config:set force_ssl=2' also sets the configuration.php to public $force_ssl = '2'.
The change should have no further effect, everywhere else in the code force_ssl is checked non type-safe.
Testing Instructions
Joomla 4.4.1
Run '/cli/joomla.php config:set force_ssl=2' and you will get public $force_ssl = '2'; in configuration.php
Actual result BEFORE applying this Pull Request
redirection to https is not wotking, site loads with http://...
Expected result AFTER applying this Pull Request
Force SSL is working, when opening with http://... the site is redirected to https://...
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
We should make sure the value is saved properly and not rely on the type converting of PHP
@rdeutz I agree, but it seems this would require a bigger change, see discussion in the other PR #42618 . And we would still have the problem when someone updates from J3 and has never edited global configuration in backend so we still have ALL values as strings in configuration.php. That's why we currently either cast the values when reading or we don't do a type safe comparison. So I think this PR here is the right fix for now, possibly with a small change like I suggested above.
| Labels |
Added:
bug
PR-4.4-dev
|
||
I have tested this item ✅ successfully on a0520bc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42615.
I have tested this item ✅ successfully on a0520bc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42615.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42615.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-10 17:16:24 |
| Closed_By | ⇒ | MacJoom |
We should make sure the value is saved properly and not rely on the type converting of PHP