[#42612] - Update SiteRouter.php - check $force_ssl non type safe
- Closed
- 5 Jan 2024
- Medium
- Build: 5.0-dev
- # 42612
- Diff
- sba:patch-2
User tests: Successful: Unsuccessful:
Summary of Changes
When updateing joomla from joomla 3 to joomla 4.4 the value in cofiguration.php is still saved with public $force_ssl = '2' instead of public $force_ssl = 2. If set as string, the force_ssl setting has no effect, the redirection to https is not working.
Furthermore, the cli command '/cli/joomla.php config:set force_ssl=2' also sets the configuration.php to public $force_ssl = '2'.
The change should have no further effect, everywhere else in the code force_ssl is checked non type-safe.
Testing Instructions
Joomla 4.4.1
Run '/cli/joomla.php config:set force_ssl=2' and you will get public $force_ssl = '2'; in configuration.php
Actual result BEFORE applying this Pull Request
redirection to https is not wotking, site loads with http://...
Expected result AFTER applying this Pull Request
Force SSL ist working, when opening with http://... the site is redirected to https://...
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Furthermore, the cli command '/cli/joomla.php config:set force_ssl=2' also sets the configuration.php to
public $force_ssl = '2'.
Shouldn't that be fixed, too (with a separate PR)?
@richard67 ok, redone in PR to 4.4 #42614
@richard67 ok, redone in PR to 4.4 #42614
@sba Yes, but unfortunately with the same branch "patch-2" as this PR here, and that branch was based on 5.0-dev, so the new PR now shows all changes between 4.4-dev and 5.0-dev, not only your changes. The solution would be tiehr to make a new PR with a branch which is based on 4.4-dev, or to rebase this PR here to the right branch and close the other one. If you want I can do that rebase for you. Shall I?
@richard67 ok, redone in PR to 4.4 #42614
@sba Yes, but unfortunately with the same branch "patch-2" as this PR here, and that branch was based on 5.0-dev, so the new PR now shows all changes between 4.4-dev and 5.0-dev, not only your changes. The solution would be tiehr to make a new PR with a branch which is based on 4.4-dev, or to rebase this PR here to the right branch and close the other one. If you want I can do that rebase for you. Shall I?
oh, silly of me.... Yes, please do the rebase for me. Thanks!
oh, silly of me.... Yes, please do the rebase for me. Thanks!
@sba I've just tried to rebase, but unfortunately that has the same result, so I have reverted thast so we can again see only your changes here in this PR.
Could you create a new branch based on the 4.4-dev branch, then make your changes there and then create a new PR with that new branch? If that works for you, you can close this one here and the other PR #42614 .
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-05 12:42:06 |
| Closed_By | ⇒ | sba | |
| Labels |
Added:
PR-5.0-dev
|
||
Thanks.
@sba As your pull request is a bug fix for a bug which happens in both 4.4.x and 5.0.y, could you shoud rebase your PR to the 4.4-dev branch, or redo it for that branch? Release managers will later care for merging it op into 5.0-dev when the fix has been tested by users and then been merged into 4.4-dev.