RTC Unit/System Tests Small PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Dec 2023

Corrects the grammar for the description of a privacy test.

simple PR that can be "tested" by code review

avatar brianteeman brianteeman - open - 14 Dec 2023
avatar brianteeman brianteeman - change - 14 Dec 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2023
Category JavaScript Unit Tests
avatar sandewt sandewt - test_item - 14 Dec 2023 - Tested successfully
avatar sandewt
sandewt - comment - 14 Dec 2023

I have tested this item ✅ successfully on 33e0688


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42521.

avatar richard67 richard67 - test_item - 14 Dec 2023 - Tested successfully
avatar richard67
richard67 - comment - 14 Dec 2023

I have tested this item ✅ successfully on 33e0688


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42521.

avatar richard67 richard67 - change - 14 Dec 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 14 Dec 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42521.

avatar richard67
richard67 - comment - 14 Dec 2023

@brianteeman Silly question: Why for 5.1-dev? As far as I could see on a quick view, the file is also present on 5.0-dev.

avatar brianteeman
brianteeman - comment - 14 Dec 2023

@richard67 because I have given up working out which version a pr should be against as different maintainers appear to follow different criteria so I am only using the latest branch and the maintainer who merges can decide what to do.

avatar LadySolveig LadySolveig - change - 16 Dec 2023
Labels Added: RTC Unit/System Tests PR-5.1-dev
avatar LadySolveig LadySolveig - change - 17 Dec 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-12-17 15:14:50
Closed_By LadySolveig
Labels Added: Small
avatar LadySolveig LadySolveig - close - 17 Dec 2023
avatar LadySolveig LadySolveig - merge - 17 Dec 2023
avatar LadySolveig
LadySolveig - comment - 17 Dec 2023

Thank you @brianteeman and also to the reviewers @sandewt and @richard67 !

Add a Comment

Login with GitHub to post a comment