User tests: Successful: Unsuccessful:
Pull Request for Issue #42503 .
added filter bt search
{{base_path}}/api/index.php/v1/tags?filter[search]=text
{{base_path}}/api/index.php/v1/content/categories?filter[search]=text
N/A
response take care of serch filter
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
iirc new feature cannot go in 4.x series, if the release lead consider this a bug fix i will do it in the 4.x branch
for test you can copy the changed lines in a j4 site
I have downloaded CategoriesController and TagsController and tested locally and it works fine.
I have tried to add another filter in the controllers displaylist:
if (\array_key_exists('alias', $apiFilterInfo)) {
$this->modelState->set('filter.alias', $filter->clean($apiFilterInfo['alias'], 'STRING'));
}
But this code doesen't work and I don't know why. The idea is to filter only by the alias field, is possible??
Sample query:
{{base_url}}/{{base_path}}/tags?filter[alias]=provatag2
Please, we need this filter search for the 4.x branch in a new version, thanks
I have tested this item ✅ successfully on c8da438
@aberenguer78 could you mark the PR as tested by you in the issue tracker? If you do, then we can mark this as ready to commit and this PR could already be in Joomla 5.1.
#42503 It's closed. I tested locally on 15th of December locally and it works fine. You, have my comments here :
#42519 (comment)
Walturbo tested it too and it's ok.
I don't know how to mark the issue as tested
I have tested this item ✅ successfully on c8da438
It was tested successfully on 15/12/2023
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-02 16:35:54 |
Closed_By | ⇒ | LadySolveig | |
Labels |
Added:
PR-5.1-dev
|
Thank you @alikon and also for testing and support @aberenguer78 @walturbo @Hackwar
Sorry I'm new adding feature requests. You mentioned me to test I don't know how to test. There's a new Joomla 4 version??
We need this feature in joomla 4 because we don't have our systems yet prepaired to migrate to joomla 5,
thanks in advance